Fix: Memory leak - Detached HTML elements #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added the fix for the auto-scroll detached element (#713 (comment)) |
taye
requested changes
May 9, 2019
|
I actually really prefer `destroy()` now 😅. I might later rename `Interactable.unset()` and leave an alias, but for now I think the inconsistency is fine since the method is only used internally and there's no corresponding `Interaction.set()`.
|
taye
reviewed
May 10, 2019
| @@ -30,7 +30,7 @@ test('Interaction constructor', (t) => { | |||
|
|
|||
| for (const coordField in interaction.coords) { | |||
| t.deepEqual(interaction.coords[coordField], zeroCoords, | |||
| `nteraction.coords.${coordField} set to zero`) | |||
| `interaction.coords.${coordField} set to zero`) | |||
Attempt to solve Memory leaks - Detached HTML elements
…and interactable reference from interactable target
taye
approved these changes
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed solution for the issue #713
This solution adds a more complete cleaning routine to the
unsetmethod in order to remove all detached elements.Also contains a little compatibility fix for the
test.shscript that was not working on my MacOs (Mojave 10.14.4).Cheers !